Create Testing chapter#73
Open
SaranjeetKaur wants to merge 14 commits into
Open
Conversation
hturner
reviewed
Sep 28, 2022
hturner
left a comment
hturner
left a comment
Member
There was a problem hiding this comment.
Some initial feedback to help your WIP
update branch
Co-authored-by: Heather Turner <ht@heatherturner.net>
hturner
reviewed
Nov 15, 2022
hturner
left a comment
hturner
left a comment
Member
There was a problem hiding this comment.
This chapter needs to focus more on the tests specific to base R, see my detailed comments.
Co-authored-by: Heather Turner <ht@heatherturner.net>
Contributor
|
@SaranjeetKaur Would you like to pick this PR up or close it given other changes that you have made? |
hturner
reviewed
Dec 3, 2024
hturner
left a comment
hturner
left a comment
Member
There was a problem hiding this comment.
I've gone through to suggest some specific changes based on my review. This probably also needs bringing up to date to reflect the change in chapter numbering.
Co-authored-by: Heather Turner <ht@heatherturner.net>
Co-authored-by: Heather Turner <ht@heatherturner.net>
SaranjeetKaur
commented
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do:
stopifnot()