add examples of a patch and reviewing a patch#271
Open
zkamvar wants to merge 1 commit into
Open
Conversation
We reviewed r-devel/r-dev-day#159 and wanted to write down the process we used. This is a simplified version of what _actually_ happened. Co-Authored-by: Mel Bather <mel.bather@gmail.com> Co-Authored-by: Nelly Tkachman <ninel.akhmadikina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reviewed r-devel/r-dev-day#159 and wanted to write down the process we used. This is a simplified version of what actually happened. We acknowledge that this can be more fleshed out, but we wanted to get to more issues :)
Summary
adding content to https://contributor.r-project.org/rdevguide/chapters/lifecycle_of_a_patch.html#examples-of-patch-reports-on-bugzilla
Addresses #235
What should a reviewer concentrate their feedback on?
Acknowledging contributors
List any contributions that need adding to the table of contributors. Common contributions are
content(adding to the guide),doc(e.g. README, wiki),infra(e.g. GitHub action), andmaintenance(e.g. fixing links). See the full key to Contribution Types.content.