Skip to content

feat: require IaC for integrated webhook enablement#377

Merged
drernie merged 3 commits intoquiltdata:mainfrom
drernie:codex/issue-341-iac-enable-guidance
Apr 11, 2026
Merged

feat: require IaC for integrated webhook enablement#377
drernie merged 3 commits intoquiltdata:mainfrom
drernie:codex/issue-341-iac-enable-guidance

Conversation

@drernie
Copy link
Copy Markdown
Member

@drernie drernie commented Apr 10, 2026

Summary

  • Setup treats disabled integrated webhooks as IaC-managed; instructs users to enable via CloudFormation/Terraform instead of mutating the stack directly
  • --force escape hatch for direct stack mutation when absolutely necessary
  • Deploy now passes PackagePrefix to CDK so EventBridge rule matches the actual runtime prefix
  • Pending canvas shows full content with disabled links instead of bare placeholder

Test plan

  • npm test (380 passed)
  • Deployed to dev, verified EventBridge rule matches benchreview/ prefix
  • Sent manual package-revision event, confirmed canvas refresh end-to-end

🤖 Generated with Claude Code

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@6130844). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage        ?   48.82%           
=======================================
  Files           ?       37           
  Lines           ?     2818           
  Branches        ?      734           
=======================================
  Hits            ?     1376           
  Misses          ?     1283           
  Partials        ?      159           
Flag Coverage Δ
typescript 48.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

drernie and others added 2 commits April 11, 2026 08:44
…C check

The IaC guard was only on the enable-integration path, leaving
disable-integration and switch-standalone able to mutate the stack
without --force. This ensures all stack mutations require IaC bypass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@drernie drernie merged commit 1f728f2 into quiltdata:main Apr 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants