Skip to content

build(deps): bump thrift from 0.17.0 to 0.23.0 in /quickwit #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build(deps): bump thrift from 0.17.0 to 0.23.0 in /quickwit #6577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions quickwit/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion quickwit/quickwit-parquet-engine/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ serde = { workspace = true }
serde_json = { workspace = true }
serde_with = { workspace = true }
thiserror = { workspace = true }
thrift = { version = "0.17", default-features = false }
thrift = { version = "0.23", default-features = false }

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep thrift aligned with parquet

When compiling quickwit-parquet-engine, this bump leaves parquet 58 locked to thrift 0.17.0 while this crate now imports thrift 0.23.0. streaming_reader.rs passes thrift::protocol::TCompactInputProtocol/TCompactOutputProtocol into PageHeader's parquet::thrift::TSerializable methods, whose protocol trait bounds come from parquet's thrift 0.17 re-export; with two thrift crate instances those are different trait/type universes, so the crate no longer type-checks. Align the direct dependency with parquet's thrift version, or update parquet at the same time.

Useful? React with 👍 / 👎.

tokio = { workspace = true }
tracing = { workspace = true }
ulid = { workspace = true }
Expand Down
Loading