Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions quickjs.c
Original file line number Diff line number Diff line change
Expand Up @@ -9779,16 +9779,6 @@ static int delete_property(JSContext *ctx, JSObject *p, JSAtom atom)
if (p->class_id == JS_CLASS_ARRAY ||
p->class_id == JS_CLASS_ARGUMENTS ||
p->class_id == JS_CLASS_MAPPED_ARGUMENTS) {
/* Special case deleting the last element of a fast Array */
if (idx == p->u.array.count - 1) {
if (p->class_id == JS_CLASS_MAPPED_ARGUMENTS) {
free_var_ref(ctx->rt, p->u.array.u.var_refs[idx]);
} else {
JS_FreeValue(ctx, p->u.array.u.values[idx]);
}
p->u.array.count = idx;
return true;
}
if (convert_fast_array_to_array(ctx, p))
return -1;
goto redo;
Expand Down
17 changes: 17 additions & 0 deletions tests/bug1430.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { assert } from "./assert.js";

const arr = [{ x: 0 }, { x: 1 }];

delete arr[1];

assert(arr.length, 2);
assert(1 in arr, false);
assert(arr[1], undefined);

arr.push({ y: 2 });

assert(arr.length, 3);
assert(1 in arr, false);
assert(2 in arr, true);
assert(arr[1], undefined);
assert(arr[2].y, 2);
Loading