Skip to content

all: slog conversion #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hdonnay wants to merge 54 commits into
base: main
Choose a base branch
from
Open

all: slog conversion #1657

hdonnay wants to merge 54 commits into from

Conversation

@hdonnay
Copy link
Member

@hdonnay hdonnay commented Oct 1, 2025 •
edited
Loading

Does what it says on the tin.

This is probably blocked on requiring go1.25 for the (testing.TB).Output method.
The log output is done via buffering in-memory on go1.24.

@hdonnay hdonnay force-pushed the hack/slog-conversion branch 3 times, most recently from 57db6c6 to b1fc880 Compare October 9, 2025 23:42
@hdonnay
Copy link
Member Author

hdonnay commented Oct 10, 2025

Depends on #1661; will rebase on main once that's merged.

@hdonnay hdonnay force-pushed the hack/slog-conversion branch 2 times, most recently from 4c8f122 to d9aa567 Compare October 31, 2025 15:18
@hdonnay hdonnay marked this pull request as ready for review October 31, 2025 15:49
@hdonnay hdonnay requested a review from a team as a code owner October 31, 2025 15:49
@hdonnay hdonnay requested review from crozzy and removed request for a team October 31, 2025 15:49
@hdonnay
Copy link
Member Author

hdonnay commented Oct 31, 2025

It's a big 'un, but there's really no way to do smaller PRs, IMO.

All the commits are (should be) pretty well scoped.

@hdonnay hdonnay force-pushed the hack/slog-conversion branch 2 times, most recently from 6bfba98 to 98dcdb9 Compare December 16, 2025 21:58
hdonnay added 17 commits December 17, 2025 11:55
@hdonnay
test: add slog shim
e5195a2 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
test: migrate to slog
919caf3 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
alpine: migrate to slog
f783a9f 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
apk: migrate to slog
d0602dc 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
aws: migrate to slog
2c66c52 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
debian: migrate to slog
185c9ce 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
test/rhel: migrate to slog
123f578 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
test/periodic: migrate to slog
c9927b7 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
test/bisect: migrate to slog
01ab25f 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
internal/dnf: migrate to slog
be6e542 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
internal/matcher: migrate to slog
10d270a 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
internal/rpm/bdb: migrate to slog
525c838 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
internal/rpm/ndb: migrate to slog
15366a2 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
internal/rpm/rpmdb: migrate to slog
33eab74 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
internal/rpm/sqlite: migrate to slog
583326d 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
internal/rpm: migrate to slog
4a8ee2a 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
datastore/postgres: migrate to slog
8b7238e 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay added 28 commits December 17, 2025 12:06
@hdonnay
test/rpmtest: migrate to slog
6736b0a 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
java/jar: migrate to slog
22e219e 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
java: migrate to slog
4e1a2c3 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
docs: migrate to slog
198e8bc 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
dpkg: migrate to slog
6e8f465 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
gobin: migrate to slog
0070719 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
libindex: migrate to slog
3fc0c2a 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
linux: migrate to slog
0eb0d29 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
matchers: migrate to slog
9b6ec89 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
nodejs: migrate to slog
27537d0 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
oracle: migrate to slog
cc20c75 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
osrelease: migrate to slog
4116d4d 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
photon: migrate to slog
b604fbf 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
python: migrate to slog
522e7fd 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
rpm: migrate to slog
8550340 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
ruby: migrate to slog
eeb9fcc 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
suse: migrate to slog
4f8f242 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
ubuntu: migrate to slog
6886d0f 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
updater/osv: migrate to slog
8d63caa 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
pkg/ovalutil: migrate to slog
54e3aa7 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
scanner/pkgconfig: migrate to slog
9200615 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
whiteout: migrate to slog
fa1635f 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
updater: migrate to slog
b41016c 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
enricher/cvss: migrate to slog
317eb9d 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
enricher/epss: migrate to slog
53b6a59 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
enricher/kev: migrate to slog
7e0ffe6 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
test: remove zlog
f4538ec 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
go.mod: remove zlog
85527f7 
🫡

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay hdonnay force-pushed the hack/slog-conversion branch from 98dcdb9 to 85527f7 Compare December 17, 2025 18:07
crozzy
crozzy requested changes Jan 2, 2026
View reviewed changes
Copy link
Contributor

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM, just one minor, it really feels like Van Halen's brown M&M

alpine/distributionscanner.go
Msg("file doesn't exist")
slog.DebugContext(ctx,
"file doesn't exist",
"path", osrelease.Path)
Copy link
Contributor

@crozzy crozzy Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"path", osrelease.Path)
"path", issuePath)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crozzy crozzy crozzy requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hdonnay @crozzy