fix(pampa): pin test fixtures and snapshots to LF#353
Merged
Conversation
core.autocrlf=true corrupts pampa's LF-committed qmd fixtures and .snap baselines to CRLF on Windows checkout, causing spurious snapshot/roundtrip/corpus test failures unrelated to actual code behavior. Mirrors the existing quarto-doctemplate/.gitattributes precedent (PR #329): pin on-disk fixtures to LF for checkout determinism, independent of the engine's CRLF-preserve policy which is exercised via in-source tests, never via file-based snapshots.
cderv
force-pushed
the
bugfix/bd-mv2ggmr5-pin-pampa-fixtures-snapshots
branch
from
466ff55 to
c4a0887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, core.autocrlf=true converts pampa's LF-committed qmd fixtures and .snap baselines to CRLF on checkout, producing snapshot, roundtrip, and corpus test failures unrelated to actual code behavior.
Mirrors the existing crates/quarto-doctemplate/.gitattributes precedent: pin fixture/snapshot/test-fixture paths to eol=lf for checkout determinism, independent of the engine's CRLF-preserve policy. That policy is exercised through in-source tests, never through file-based snapshots, so pinning these paths to LF does not weaken or bypass CRLF coverage.
Test Plan
cargo nextest run -p pampapasses unit_test_snapshots_native and test_qmd_roundtrip_consistency