Workflow generation extension and CLI#381
Conversation
iocanel
force-pushed
the
workflow-generator
branch
from
3042a65 to
a852a2c
Compare
gsmet
left a comment
gsmet
left a comment
There was a problem hiding this comment.
Am I right that it's not related at all to what this extension is currently doing (i.e. allow developing GitHub Actions with Quarkus)?
Asking because I'm not completely sure we should tie the two together and maybe this should be hosted in another repository.
I also spotted a few issues that you will want to fix, whether we end up including this code here or elsewhere.
| "quarkus-github-action-workflow-generator", null, | ||
| "jar", GenerateCommand.getVersion()); | ||
|
|
||
| @Parameters(arity = "0..1", paramLabel = "GENERATION_PATH", description = " The path to generate the Helm Charts") |
| @@ -0,0 +1,3 @@ | |||
| quarkus.log.level=ERROR | |||
| quarkus.log.category."com.fasterxml.jackson".level=DEBUG | |||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-devtools-common</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
I'm puzzled you have to adjust the original extension?
There was a problem hiding this comment.
I don't. Left overs after moving things around. Removing it.
iocanel
force-pushed
the
workflow-generator
branch
from
a852a2c to
a23722d
Compare
|
@gsmet: Applied your feedback. Also, you are right. This feature has nothing to do with the existing functionality it's just that both are related to github actions. I want to avoid having multiple different extension related to github actions, so I added the extension here. I am open to move the code elsewhere if it makes more sense. We briefly discussed that with @maxandersen, too. wdyt ? |
2 participants
The pull request introduces a mini extension that can be used to automatically generate a github action.
Additionally, it introduces a CLI module that can now be used
generatethe workflow without needing to add any extension to the mix.