[AArch64] Add overflow check for R_AARCH64_ADR_PREL_PG_HI21#1330
Draft
Shankar Easwaran (quic-seaswara) wants to merge 1 commit into
Draft
[AArch64] Add overflow check for R_AARCH64_ADR_PREL_PG_HI21#1330Shankar Easwaran (quic-seaswara) wants to merge 1 commit into
Shankar Easwaran (quic-seaswara) wants to merge 1 commit into
Conversation
Shankar Easwaran (quic-seaswara)
requested a review
from Parth (parth-07)
as a code owner
Shankar Easwaran (quic-seaswara)
requested review from
Eli Friedman (efriedma-quic),
Parth (parth-07) and
quic-areg
and removed request for
Parth (parth-07)
The ADRP instruction encodes (PG(S+A) - PG(P)) >> 12 in a 21-bit signed immediate field. Add a signed 21-bit range check for R_AARCH64_ADR_PREL_PG_HI21; the _NC (no-check) variant intentionally skips the check. Add a lit test that verifies a link within range succeeds and a link that overflows the 21-bit field is caught with an overflow diagnostic. Fixes #1329 Signed-off-by: Shankar Easwaran <seaswara@qti.qualcomm.com>
Shankar Easwaran (quic-seaswara)
force-pushed
the
R_AARCH64_ADR_PREL_PG_HI21_overflow
branch
from
34bbc03 to
196247d
Compare
Shankar Easwaran (quic-seaswara)
removed request for
Eli Friedman (efriedma-quic),
Parth (parth-07) and
quic-areg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADRP instruction encodes (PG(S+A) - PG(P)) >> 12 in a 21-bit signed immediate field. Add a signed 21-bit range check for R_AARCH64_ADR_PREL_PG_HI21; the _NC (no-check) variant intentionally skips the check.
Add a lit test that verifies a link within range succeeds and a link that overflows the 21-bit field is caught with an overflow diagnostic.