Fix RB8 overlay audio rerun failures by making PipeWire overlay setup idempotent#293
Closed
smuppand wants to merge 1 commit intoqualcomm-linux:mainfrom
Closed
Fix RB8 overlay audio rerun failures by making PipeWire overlay setup idempotent#293smuppand wants to merge 1 commit intoqualcomm-linux:mainfrom
smuppand wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
Legal: update SPDX license from BSD-3-Clause-Clear to BSD-3-Clause
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On overlay builds (audioreach modules present), repeated runs of AudioRecord can FAIL on RB8 because the overlay setup path restarts PipeWire every run. After the first successful setup (until reboot), subsequent
systemctl restart pipewireattempts can fail/hang and cause the testcase to report FAIL even though the audio stack is otherwise usable.What this PR changes
This PR fixes the issue #291 reported on RB8
Runner/utils/audio_common.sh
setup_overlay_audio_environment()idempotent for overlay builds:systemctl/wpctlcalls using existing timeout wrappers to avoid control-plane hangs.Runner/suites/Multimedia/Audio/AudioRecord/run.sh
[audio_common.sh](http://audio_common.sh/)(e.g., PipeWire source default helper where applicable).[audio_common.sh](http://audio_common.sh/)).