Added automation of Virsh commands#285
Open
Rohan-in-Qualcomm wants to merge 1 commit intoqualcomm-linux:mainfrom
Open
Added automation of Virsh commands#285Rohan-in-Qualcomm wants to merge 1 commit intoqualcomm-linux:mainfrom
Rohan-in-Qualcomm wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
Contributor
|
Please fix the checks |
smuppand
requested changes
Feb 13, 2026
Contributor
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
These changes are not aligned with the repository standards. Please review the contributions README and update accordingly.
| @@ -0,0 +1,44 @@ | |||
| #!/bin/bash | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Please avoid creating a custom folder with your username and sending the pull request.
Author
There was a problem hiding this comment.
I have deleted the folder
Rohan-in-Qualcomm
force-pushed
the
Virtualization
branch
2 times, most recently
from
381bdf3 to
9346e9d
Compare
Author
|
Updated the PR with the requested changes. |
Rohan-in-Qualcomm
force-pushed
the
Virtualization
branch
from
9346e9d to
4a8837d
Compare
This PR refactors the Virsh Commands into a modular suite of independent KVM test cases. Key Changes: Modular Architecture: Split the original script into 5 standalone test cases: Kvm-Setup: Defines and starts the VM. Kvm-Reboot: Verifies reboot functionality. Kvm-Suspend: Verifies suspend/pause functionality. Kvm-Resume: Verifies resume functionality. Kvm-UnDefine: Verifies destroy and undefine functionality. Common Library: Created kvm_common.sh to handle shared logic (define, start, clean, state checks) and reduce code duplication. Robust State Verification: Replaced simple exit code checks with a check_vm_state function that parses virsh domstate output to ensure the VM is actually in the expected state (e.g., "running", "paused", "shut off"). Independence: Each test script now manages its own lifecycle (Setup -> Test -> UnDefine), allowing them to be run individually or in any order. Reporting: Added .res file generation (PASS/FAIL) and LAVA-compatible .yaml metadata for automation integration. Signed-off-by: Rohan Dutta <rohadutt@qti.qualcomm.com>
Rohan-in-Qualcomm
force-pushed
the
Virtualization
branch
from
4a8837d to
cc5c15c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Virsh Commands into a modular suite of independent KVM test cases.
Key Changes:
Created kvm_common.sh to handle shared logic (define, start, clean, state checks) and reduce code duplication.
Robust State Verification: Replaced simple exit code checks with a check_vm_state function that parses virsh domstate output to ensure the VM is actually in the expected state (e.g., "running", "paused", "shut off").
Independence: Each test script now manages its own lifecycle (Setup -> Test -> Undefine), allowing them to be run individually or in any order.
Reporting: Added .res file generation (PASS/FAIL) and LAVA-compatible .yaml metadata for automation integration.