Enable ethernet on Talos Ride SX#267
Open
ayaan-anwar wants to merge 3 commits intoqualcomm-linux:qcom-6.18.yfrom
Open
Enable ethernet on Talos Ride SX#267ayaan-anwar wants to merge 3 commits intoqualcomm-linux:qcom-6.18.yfrom
ayaan-anwar wants to merge 3 commits intoqualcomm-linux:qcom-6.18.yfrom
Conversation
qcom-sarohasa
left a comment
qcom-sarohasa
left a comment
There was a problem hiding this comment.
Change looks fine.
Reviewed-by: Sarosh Hasan sarosh.hasan@oss.qualcomm.com
ayaan-anwar
force-pushed
the
talos_eth
branch
2 times, most recently
from
12146cb to
f6ad204
Compare
ayaan-anwar
changed the title
ayaan-anwar
force-pushed
the
talos_eth
branch
2 times, most recently
from
5f44dc3 to
79d87d2
Compare
shashim-quic
requested changes
Feb 13, 2026
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
WORKAROUND: net: stmmac: Inverse the phy-mode definition
Please use FROMLIST for all submitted patches.
ayaan-anwar
force-pushed
the
talos_eth
branch
from
79d87d2 to
9785ae2
Compare
Author
Done |
ayaan-anwar
force-pushed
the
talos_eth
branch
from
9785ae2 to
b0a3935
Compare
In the initial device tree submission, the definitions of rgmii and rgmii-id in the phy-mode property were inverted compared to the conventions used by the upstream Linux kernel community. Only QCS-EVB-400 and SA8155-ADP platforms are affected due to the incorrect PHY mode configuration: 'rgmii' was used instead of the correct 'rgmii-id'. This change results in an ABI compatibility break, but it is acceptable as these platforms are not actively used by any customers, based on current observations. Qualcomm expects the MAC, not the PHY, to introduce the timing delay, and the driver is designed accordingly. This is due to specific SoC hardware that handles delay and sampling internally. Link: https://lore.kernel.org/netdev/20250819-qcs615_eth-v4-2-5050ed3402cb@oss.qualcomm.com/ Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
ayaan-anwar
force-pushed
the
talos_eth
branch
from
b0a3935 to
3601dd9
Compare
Add an ethernet controller node for QCS615 SoC to enable ethernet functionality. Link: https://lore.kernel.org/netdev/20250819-qcs615_eth-v4-3-5050ed3402cb@oss.qualcomm.com/ Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Enable the ethernet node, add the phy node and pinctrl for ethernet. Link: https://lore.kernel.org/netdev/20250819-qcs615_eth-v4-4-5050ed3402cb@oss.qualcomm.com/ Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
ayaan-anwar
force-pushed
the
talos_eth
branch
from
3601dd9 to
74fe063
Compare
shashim-quic
requested changes
Feb 13, 2026
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
Only boot critical and CI blockers taken as workaround. Rest all should be submitted upstream.
Else WORKAROUND can end up becoming a parking place of all enablements.
ayaan-anwar
force-pushed
the
talos_eth
branch
from
74fe063 to
361fefe
Compare
Author
Ack. I have dropped the WORKAROUND commit and kept just the FROMLIST changes. |
ayaan-anwar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to issues with how the Talos EMAC handles RGMII delays, Ethernet functionality has not been approved in upstream. We are working with the HW team to come up with a solution that is aligned to upstream expectations. Until then, this PR adds the necessary changes to enable ethernet on the Talos Ride SX board. The QLIJIRA, approved for this temporary exception, is linked below.
All three commits are FROMLIST, aged-out patches that will enable 1G ethernet on Talos Ride SX. We need them for QLI 2.0 temporarily until we figure out the correct HW programming to align with upstream preferred behavior.
QLIJIRA: QLIJIRA-101
QLI0.0-PR: qualcomm-linux/kernel-topics#678
CRs-Fixed: 4436907
Signed-off-by: Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com