Fix magebox db commands failing with exit 127 on MariaDB 11.x - #142
Merged
Conversation
…riadb-admin binaries (#122) Co-authored-by: peterjaap <431360+peterjaap@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix magebox db commands for MariaDB 11.x
Fix Sep 1, 2026
magebox db commands failing with exit 127 on MariaDB 11.x
peterjaap
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MariaDB 11.0+ removed the
mysql/mysqldump/mysqladminsymlinks — only the nativemariadb/mariadb-dump/mariadb-adminbinaries exist. Alldbsubcommands hardcoded the old names, causing OCI exec failures.Changes
internal/docker/compose.go— addsDBClientBin(dbType, version)andDBDumpBin(dbType, version)as the single source of truth for binary selection; updatesCreateDatabaseandDatabaseExiststo accept aclientBinparameter instead of hardcoding"mysql"cmd/magebox/db.go— addsclientBin(),dumpBin(),adminBin()methods ondbInfo, each delegating to the shared helpers; replaces all 12 hardcoded binary references throughoutdb import,db export,db shell,db create,db drop,db reset,db top,db snapshot create/restoreinternal/project/lifecycle.go,cmd/magebox/check.go— updated call sites pass the version-resolved binary nameinternal/docker/compose_test.go— table-driven tests forDBClientBin/DBDumpBinacross MySQL and MariaDB 10.x/11.x/12.x