Script for moving from Valet to Magebox. ADD default SSL catch-all vhost to prevent wrong certificate on unregistered sites - #123
Open
henkvalk wants to merge 2 commits into
Conversation
…istered sites When multiple projects share nginx but not all have a domain vhost yet (common after Valet migration), the first loaded SSL server block would serve its certificate for all unknown hostnames — causing ERR_CERT_COMMON_NAME_INVALID in the browser. MageBox now installs 000-magebox-default-ssl.conf with ssl_reject_handshake so unregistered hostnames get a clean TLS rejection instead of a mismatched certificate. The file is created on Generate() and SetupNginxConfig(). Also improves `magebox check`: - Suggests 'magebox global start' instead of 'brew services start nginx' - Detects missing domain vhosts to warn about wrong certificate
henkvalk
force-pushed
the
move-from-valet-to-magebox
branch
from
May 25, 2026 09:47
26a4af6 to
8584175
Compare
henkvalk
changed the title
Scripts to move databases from Homebrew MySQL to MageBox Docker MySQL and patch project configs (env.php, .env, wp-config.php) for all parked Valet sites. Includes --start-projects to register nginx SSL vhosts.
henkvalk
changed the title
Collaborator
|
@henkvalk can you move the Valet migration part to a separate PR? I'm not sure I want that in here.. |
peterjaap
pushed a commit
that referenced
this pull request
Aug 7, 2026
The comment-artifacts job requests pull-requests: write, but GitHub caps GITHUB_TOKEN to read-only for pull_request runs originating from a fork. Posting the comment therefore fails with 403 'Resource not accessible by integration', marking the whole run as failed even when every build, test and lint job passed. This has broken every fork PR since 1fe4817 added the job (#128, #133, and external contributions such as #123). PRs from branches in this repository are unaffected and keep their artifact comment. Gate the job on the PR originating from this repository instead of merely being a pull_request. On push events github.event.pull_request is null, so the job is still skipped there, matching the previous guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check command now: