Declare @mui/utils, @mui/system, @uppy/status-bar as direct deps#391
Open
quetz wants to merge 1 commit into
Open
Declare @mui/utils, @mui/system, @uppy/status-bar as direct deps#391quetz wants to merge 1 commit into
quetz wants to merge 1 commit into
Conversation
These packages were imported from source but only present in node_modules transitively via @mui/material and @uppy/react. npm and yarn classic hoist transitive dependencies into a flat node_modules, so the imports happened to resolve; package managers that isolate transitive deps (pnpm in strict mode, yarn PnP) fail to build with "Rollup failed to resolve import" errors. - Add @mui/utils as a direct dep (used by src/theme/index.js for deepmerge). - Switch src/components/Common/Circle.jsx to import Box from @mui/material rather than @mui/system, since @mui/material is already a declared dep and re-exports Box. - Add @uppy/status-bar as a direct dep (its stylesheet is imported by src/components/Snapshots/SnapshotUploadForm.jsx).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few packages are imported from source but only present in
node_modulestransitively (via@mui/material/@uppy/react). npm and yarn classic hoist transitive deps into a flatnode_modulesso these imports happen to resolve, but pnpm in strict mode fails the build withRollup failed to resolve import.@mui/utilsas a direct dep (used bysrc/theme/index.jsfordeepmerge).Circle.jsx, importBoxfrom@mui/materialinstead of@mui/system—@mui/materialre-exports it and is already declared.@uppy/status-baras a direct dep — its stylesheet is imported bySnapshotUploadForm.jsx.