You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
new: make memory-mapping of static embeddings optional - #808
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 485d0c3c-e52b-468f-a0fc-ef41298f0836
📥 Commits
Reviewing files that changed from the base of the PR and between 8f3bd6f and 9958675.
📒 Files selected for processing (4)
fastembed/common/safetensors_utils.py
fastembed/text/static_embedding.py
fastembed/text/text_embedding.py
tests/test_static_embeddings.py
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
📝 Walkthrough
Walkthrough
load_safetensors now supports an optional mmap mode. StaticTextEmbedding passes this option through model loading and embedding workers. Tests cover mapped and in-memory loading, including batched and parallel embedding. The TextEmbedding constructor documentation now describes its arguments and supported keyword options.
The change adds opt-in memory mapping for static embeddings while leaving default loading unchanged. The reviewed concerns were refuted, and no concrete merge-blocking risk remains.
Pre-merge checks · 3 · 1 · 1
Failed checks (1 warning, 1 inconclusive)
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 4 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check
No pull request description was provided, so the description cannot be assessed for relevance to the changeset.
Add a brief description of the optional memory-mapping support for static embeddings.
Passed checks (3 passed)
Check name
Status
Explanation
Title check
The title clearly and concisely describes the primary change: optional memory-mapping for static embeddings.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.