Skip to content

new: check wheel before publishing - #783

Merged
joein merged 1 commit into
mainfrom
add-publish-smoke-test
Oct 6, 2026
Merged

joein merged 1 commit into
mainfrom
add-publish-smoke-test

Conversation

@joein

@joein joein commented Oct 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2b4416e7-3350-418f-8665-caf9630ffcab
📥 Commits

Reviewing files that changed from the base of the PR and between b566dcb and 974c951.

📒 Files selected for processing (1)
  • .github/workflows/python-publish.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The publish workflow now tests the built wheel before publishing. It installs the wheel in a temporary virtual environment, imports TextEmbedding, generates an embedding for “hello world” with sentence-transformers/all-MiniLM-L6-v2, and checks that the result shape is (384,). A failed check interrupts the workflow before publication.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 974c9

The new check validates the installed wheel before publication and prevents publishing if it fails. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was added, so the description provides no information about the changes. Add a brief description stating that the workflow smoke-tests the built wheel before publishing.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a wheel check before publishing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joein
joein merged commit 0abff4d into main Oct 6, 2026
17 checks passed
@joein
joein deleted the add-publish-smoke-test branch October 6, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant