Skip to content

new: add weekly ci to check updates on hf - #782

Closed
joein wants to merge 1 commit into
mainfrom
add-weekly-hf-repo-check
Closed

joein wants to merge 1 commit into
mainfrom
add-weekly-hf-repo-check

Conversation

@joein

@joein joein commented Oct 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 259d7016-0a11-4696-90f1-c8f0732ff8a0
📥 Commits

Reviewing files that changed from the base of the PR and between 0db8d09 and 84236e1.

📒 Files selected for processing (2)
  • .github/scripts/check_model_updates.py
  • .github/workflows/weekly-model-updates.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

Adds a script that checks supported Hugging Face model repositories for recent commits and file changes. It reports changes and can write issue data. A new workflow runs the check weekly or manually. When issue data exists and the run meets the publishing conditions, the workflow creates or updates model issues.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 84236

This change adds a weekly check for updates to supported Hugging Face model repositories and can optionally open or update GitHub issues. It does not change library runtime behavior. No blocking problems were found, so it is ready to merge.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 84236

The automation separates repository checking from issue-writing authority and does not execute fetched metadata. However, it can publish metadata obtained using a secret without checking repository visibility. The secret’s access scope and the publication audience need confirmation.

Retained concerns

  • Medium · security · inferred: The new checker follows externally supplied upstream repository identifiers and publishes successfully fetched metadata without checking its visibility. If HF_TOKEN permits private reads and the issue or summary audience is broader, an upstream-card author could cause repository names, changed paths and commit metadata to cross that confidentiality boundary. Actual credential scope and audience exposure remain unverified.
Security review details

Security Blast Radius

  • inferred — Publication authority is confined to issues in the current GitHub repository. Conditional confidentiality exposure extends to upstream repositories reachable by the checker’s credential and selected through supported source cards. The inspected path exposes metadata, not model-file contents or credentials.

Security Findings and Attack Paths

  • inferred — An actor able to modify a tracked export repository’s model card can supply upstream identifiers. If those identifiers resolve to private repositories readable by HF_TOKEN, their recent commit and path metadata can enter automated reports and model-update issues. Disclosure requires a broader destination audience; neither that audience nor private-read access was verified.

Trust Boundaries and Controls

  • observed — Fetched metadata crosses into issue content through JSON parsing, quoted arguments and a body file, rather than shell evaluation. Issue titles derive from local supported-model names, and issue matching uses exact title equality. These controls constrain command execution and target selection, but do not enforce metadata confidentiality.

Resilience and Maintainability Implications

  • observed — Lookup and fetch failures are recorded in the report and reflected in the checker’s exit status. Results are uploaded before the workflow explicitly fails the check job, preserving valid partial findings while making incomplete scanning visible. Published issues do not carry the complete scan-error report.

Hardening Proposals

  • proposed — Use unauthenticated lookups for externally selected upstream repositories where feasible, or restrict the checker credential to approved public sources. Enforce an explicit visibility and publication policy before metadata enters summaries, artifacts or issues.
🚥 Pre-merge checks | ✅ 3 | ❌ 1 | ❓ 1

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 29.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 1 files. (1 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the description does not give meaningful information about the changes. Add a brief description of the weekly Hugging Face model update check and its reporting or issue-opening behavior.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a weekly CI check for Hugging Face model updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 29.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joein joein closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant