Skip to content

fix(image): respect do_resize=False in ConvNeXT preprocessing #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joein merged 3 commits into from
Oct 5, 2026
+3 −0
Merged

fix(image): respect do_resize=False in ConvNeXT preprocessing #771

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3c40f7
fix(image): respect do_resize=False in ConvNeXT preprocessing
RAMZI0TO99 Oct 4, 2026
02a1aad
test: drop tests
joein Oct 5, 2026
97e6734
fix: move convnext comment
joein Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fastembed/image/transform/operators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,9 @@ def _get_resize(cls, transforms: list[Transform], config: dict[str, Any]) -> Non
)
)
elif mode == "ConvNextFeatureExtractor":
# HF defaults do_resize to True for ConvNeXT; it also gates the coupled crop
if not config.get("do_resize", True):
return
if "size" in config and "shortest_edge" not in config["size"]:
raise ValueError(
f"Size dictionary must contain 'shortest_edge' key. Got {config['size'].keys()}"
Expand Down
Loading