Skip to content

new: add constella - #751

Merged
joein merged 1 commit into
mainfrom
add-constella
Sep 29, 2026
Merged

joein merged 1 commit into
mainfrom
add-constella

Conversation

@joein

@joein joein commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

I reran experiments for NFCorpus and got the following results:
Qdrant/constella-nano - 0.363080 - Exact match
Qdrant/constella-zero- 0.312416 - Matches at the card's precision
Qdrant/stella-en-400M-v5-doc-onnx with the s2p_query prompt - 0.413415 - Matches at the card's precision

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4aded34e-fe9c-4f59-b764-cfa2f2d5e674

📥 Commits

Reviewing files that changed from the base of the PR and between b50831a and cb25100.

📒 Files selected for processing (3)
  • fastembed/text/onnx_embedding.py
  • fastembed/text/pooled_normalized_embedding.py
  • tests/test_text_onnx_embeddings.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The supported ONNX model catalog adds Qdrant/constella-zero and Qdrant/stella-en-400M-v5-doc-onnx. The pooled normalized model catalog adds Qdrant/constella-nano. The ONNX embedding test fixture adds canonical vectors for all three models.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to cb251

The new model entries use their intended embedding paths and have canonical-vector checks when selected. No concrete load or output failure is established; external artifacts still need normal validation.

Security Architecture Review

Security architecture risk: 🔵 Low · up to cb251

The new embedding options use existing selection and download controls. They add a limited external-artifact trust dependency when selected, but no boundary bypass or security finding was established.

Retained concerns

  • Low · security · inferred: The newly selectable models add three remote artifact sources without immutable revisions in their catalog descriptors. A deployment that selects them consequently extends its artifact trust to those upstream repositories; existing cache-integrity checks do not by themselves establish a fixed publisher version.
Security review details

Security Blast Radius

  • inferred — The incremental exposure is limited to processes that select an added model and obtain its artifact; no deployed tenant, service, or environment scope is established by the available evidence.

Trust Boundaries and Controls

  • inferred — An arbitrary caller-supplied model name does not become an arbitrary download source: registry matching precedes construction. The shared downloader checks cached-file metadata, but that control does not establish an immutable revision for a newly added repository.

Hardening Proposals

  • proposed — Where deployments require reproducible, high-trust artifacts, pin or independently verify the revisions used for these new model sources.
🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided. The description check cannot confirm that the author documented the changeset. Add a brief description that states which Constella and Stella models were added and that their expected embedding values were added to the tests.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the primary change: adding Constella models. It is concise and related to the changeset, although it does not mention the additional Stella model.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Dylan Couzon <dylan.couzon@qdrant.com>
@joein
joein merged commit a56e1e1 into main Sep 29, 2026
17 checks passed
@joein
joein deleted the add-constella branch September 29, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant