Skip to content

fix: round Jina CLIP crop offsets to match Jina's reference #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joein merged 1 commit into from
Sep 25, 2026
Merged

fix: round Jina CLIP crop offsets to match Jina's reference #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fastembed/image/transform/functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,16 @@ def pad2square(
left, right = 0, width
top, bottom = 0, height

# Jina's reference crops with torchvision's CenterCrop, which rounds the offset half to
# even like round() instead of flooring it: a 227 px edge is cropped from 2, not 1
crop_required = False
if width > size:
left = (width - size) // 2
left = round((width - size) / 2)
right = left + size
crop_required = True

if height > size:
top = (height - size) // 2
top = round((height - size) / 2)
bottom = top + size
crop_required = True

Expand Down
Loading