Skip to content

fix: time out model_info so a silent hf endpoint can't hang download_… - #730

Merged
joein merged 1 commit into
mainfrom
fix-hf-metadata-timeout
Sep 24, 2026
Merged

joein merged 1 commit into
mainfrom
fix-hf-metadata-timeout

Conversation

@joein

@joein joein commented Sep 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f8bf917e-a4d6-404f-afe2-b7f5d390985d

📥 Commits

Reviewing files that changed from the base of the PR and between 8583de3 and 4c848dd.

📒 Files selected for processing (1)
  • fastembed/common/model_management.py

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

download_files_from_huggingface now passes HF_HUB_ETAG_TIMEOUT to model_info when it looks up the repository revision.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: he-yufeng

Merge Risk: ⚪ Minimal · up to 4c848

No actionable merge-blocking risk remains. The timeout API is supported across the inspected Hugging Face Hub versions permitted by the project.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the description cannot be assessed for relevance. Add a brief description that explains the model_info timeout change and its effect on Hugging Face downloads.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: adding a timeout to model_info so a silent Hugging Face endpoint does not block downloads.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joein
joein merged commit e3867c8 into main Sep 24, 2026
10 checks passed
@joein
joein deleted the fix-hf-metadata-timeout branch September 24, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant