Skip to content

fix: use cached gcs copies after hf failures, don't warn for custom urls #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joein merged 1 commit into from
Sep 24, 2026
Merged

fix: use cached gcs copies after hf failures, don't warn for custom urls #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions fastembed/common/model_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,15 +396,17 @@ def retrieve_model_gcs(

# check if the model_dir and the model files are both present for macOS
if model_dir.exists() and len(list(model_dir.glob("*"))) > 0:
if deprecated_tar_struct:
if deprecated_tar_struct and not source_url:
# No built-in model is served from the bucket anymore, only copies of it remain.
# stacklevel points at the caller of TextEmbedding(...), the path that gets here.
# A model with a url of its own (a custom one) got its copy from there instead.
# stacklevel points at the caller of TextEmbedding(...) via download_model.
warnings.warn(
f"Loading {model_name} from {model_dir}, a copy downloaded from Google Cloud "
"Storage by an older fastembed version. Support for such copies is deprecated "
"and will be removed in a future release. To switch to Hugging Face, load the "
"model once with network access (without `local_files_only=True` or "
f"`HF_HUB_OFFLINE=1`), then delete {model_dir}.",
"model once while huggingface.co (or an `HF_ENDPOINT` mirror) is reachable, "
"without `local_files_only=True` or `HF_HUB_OFFLINE=1`, then delete "
f"{model_dir}.",
FutureWarning,
stacklevel=5,
)
Expand Down Expand Up @@ -547,14 +549,25 @@ def download_model(cls, model: T, cache_dir: str, retries: int = 3, **kwargs: An
try:
return cls.retrieve_model_gcs(
model.model,
str(url_source),
url_source or "",
str(cache_dir),
deprecated_tar_struct=model.sources.deprecated_tar_struct,
local_files_only=local_files_only,
)
except Exception:
if not local_files_only:
logger.error(f"Could not download model from url: {url_source}")
elif model.sources.deprecated_tar_struct:
# Nothing is downloaded from the bucket anymore, but an old copy may still be cached.
legacy_dir = Path(cache_dir) / f"fast-{model.model.split('/')[-1]}"
if legacy_dir.is_dir() and any(legacy_dir.iterdir()):
return cls.retrieve_model_gcs(
model.model,
"",
str(cache_dir),
deprecated_tar_struct=True,
local_files_only=True,
)

if local_files_only:
logger.error("Could not find model in cache_dir")
Expand Down
Loading