configs(nova-bf): url should-conditions before the text must in ms_marco filtered configs#49
Closed
Seth Ockerman (OckermanSethGVSU) wants to merge 1 commit into
Closed
configs(nova-bf): url should-conditions before the text must in ms_marco filtered configs#49Seth Ockerman (OckermanSethGVSU) wants to merge 1 commit into
Seth Ockerman (OckermanSethGVSU) wants to merge 1 commit into
Conversation
Readability-only reorder of the ms_marco_5000_filtered configs (also brings these previously-untracked run configs into the repo). evaluate() tokenizes each referenced field once and combines conditions order-insensitively, so YAML order has no performance or semantic effect — noted in the config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorders the
filterblock inms_marco_5000_filtered.yamland its smoke variant so the nine smallurldomain_slot_*should-conditions are listed before the bigtextmust-condition, and commits these previously-untracked run configs.No behavior or performance change — verified: since #48,
evaluate()tokenizes each referenced field exactly once (_text_prep) and combines conditions order-insensitively (_static_first+ the fused query-major combine), so YAML condition order carries no weight. Both configs parse to an identicalFilterobject before and after. A comment in each config records this so nobody later assumes order matters.Note for anyone pulling this after merge: local untracked copies of these two files will block checkout — overwrite them with the committed versions.
🤖 Generated with Claude Code