add milvus + elastic as a load backend#28
Open
Nathan LeRoy (nleroy917) wants to merge 3 commits into
Open
Conversation
| Ok(()) | ||
| } | ||
|
|
||
| async fn enable_indexing(&self) -> Result<(), StoreError> { |
Collaborator
There was a problem hiding this comment.
This does not "enable indexing". Milvus flushes open segments based on size thresholds from the get go. This flushes all open segments, which marks them as eligible for indexing. Not sure if this is important or not but worth mentioning
Collaborator
Author
|
Tested the milvus backend and the elastic backend -- both look good. Using the following configs: source:
type: huggingface_parquet
dataset_name: mteb/tweet_sentiment_extraction
split: train
text_field: text
dense_embedder:
type: sentence_transformer
model: sentence-transformers/all-MiniLM-L6-v2
batch_size: 128
dtype: bfloat16
sparse_embedder:
type: fastembed
model: Qdrant/bm25
batch_size: 256
storage:
type: local
output_dir: /tmp/mteb_tweets_all-MiniLM-L6-v2
pipeline:
chunk_size: 1000
flush_threshold: 10000loading: datasource:
type: local
path: /tmp/mteb_tweets_all-MiniLM-L6-v2
id_expression: "vf_point_id(filename, file_row_number)"
payload_fields:
text: text # plain column
label: label
label_text: label_text
tweet_id: id
vectors:
dense:
type: dense
column: dense_embedding
distance: cosine
sparse:
type: sparse
column: sparse_embedding
vectorstore:
type: milvus
url: http://localhost:19530
collection_name: mteb_tweets
# username: root
# password: ${MILVUS_PASSWORD}
# id_max_length: 128 # bump if your ids exceed this
recreate: false
loader:
batch_size: 256
concurrency: 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.