Revise some inconsistencies in the Makefile - #198
Open
mhei wants to merge 5 commits into
Open
Conversation
Add conventional DESTDIR, prefix, bindir, and mandir variables while retaining ROOTFS compatibility for existing callers. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Remove hard-coded owner and group options from install targets so staged and unprivileged installs can use the caller's ownership policy. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Leave raw socket privilege policy to distributors and install the tools with ordinary executable permissions by default. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Use append assignments so flags supplied by the environment are retained alongside the project defaults. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Use standard permissions, used by most common distributions. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes some "inconsistencies" that I've been unhappy with for a long time.
None of them are actual blockers, but for the sake of a well-maintained codebase, I wanted to suggest them for review.