Skip to content

Added boundary check to numGroups to avoid buffer overflow #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1000 merged 1 commit into from
Sep 7, 2026
Merged

Added boundary check to numGroups to avoid buffer overflow #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions slac/evse_cm_mnbc_sound.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ signed evse_cm_mnbc_sound (struct session * session, struct channel * channel, s

#endif

if (indicate->NumGroups > SLAC_GROUPS)
{
indicate->NumGroups = SLAC_GROUPS;
}

for (session->NumGroups = 0; session->NumGroups < indicate->NumGroups; session->NumGroups++)
{
AAG [session->NumGroups] += indicate->AAG [session->NumGroups];
Expand Down
4 changes: 4 additions & 0 deletions slac/pev_cm_atten_char.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ signed pev_cm_atten_char (struct session * session, struct channel * channel, st
memcpy (session->EVSE_MAC, indicate->ethernet.OSA, sizeof (session->EVSE_MAC));
session->NUM_SOUNDS = indicate->ACVarField.NUM_SOUNDS;
session->NumGroups = indicate->ACVarField.ATTEN_PROFILE.NumGroups;
if (session->NumGroups > SLAC_GROUPS)

@n1000 n1000 Sep 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be checking and overwriting the value in indicate->ACVarField.ATTEN_PROFILE.NumGroups, I'll take care of this in a follow up commit.

{
session->NumGroups = SLAC_GROUPS;
}
memcpy (session->AAG, indicate->ACVarField.ATTEN_PROFILE.AAG, indicate->ACVarField.ATTEN_PROFILE.NumGroups);

#if SLAC_DEBUG
Expand Down