Repository navigation
feat(schema): derive JsonSchema for multi-network models - #900
Merged
jetuk merged 1 commit intoOct 9, 2026
Merged
Conversation
jetuk
approved these changes
Oct 9, 2026
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pywr-cli export-schemawrites the JSON Schema forModelSchema, but the multi-network model types (MultiNetworkModelSchemaand the types it contains) do not deriveJsonSchema, so a multi-network file has no schema to validate against and cannot be part of a combined schema.This adds the derive on those four types and nothing else, so a schema can be generated for them with
schema_for!the same way as forModelSchema. No behaviour changes: the derive only adds a trait implementation.It is needed by #901, which uses it to export one schema for v1 and v2 model files. This change does not depend on that work.