Run InterGeneratorRouter inside a monarch actor - #4069
Open
pzhan9 wants to merge 1 commit into
Open
Conversation
pzhan9
force-pushed
the
inter_generator_router_actor
branch
from
August 5, 2026 18:28
2b4cda7 to
34393d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InterGeneratorRouterhas mutable states such as generator load and lifecycle state. Its current implementation is not safe to share across threads or processes. This blocks it from being used concurrently from multiple processes.To solve this problem, this PR add a
InterGeneratorRouterActor, which is a Monarch Actor wrapper. This actor is spawned on its dedicate process as a singleton Monarch actor mesh. In this way, the router can be accessed concurrently through this actor.Currently the actor is only used by controller. This PR is mainly to set up the stage so we later can: