Skip to content

Bind optimizer redistribution topology per bucket - #4056

Closed
weifengpy wants to merge 3 commits into
weifeng/distributed-muon-tp-shard1from
weifeng/distributed-muon-bucket-mesh
Closed

Bind optimizer redistribution topology per bucket#4056
weifengpy wants to merge 3 commits into
weifeng/distributed-muon-tp-shard1from
weifeng/distributed-muon-bucket-mesh

Conversation

@weifengpy

@weifengpy weifengpy commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Stack:

Summary:

  • add a runtime DeviceMesh to each optimizer BucketSpec and interpret owner ranks within that mesh
  • move process-group selection and DTensor storage-block derivation into the generic bucketed redistribution runtime
  • resolve static DSV3 BucketConfig entries against named DTensor mesh axes after model parallelization
  • remove optimizer-wide control-mesh coordination; setup and missing-gradient validation fail locally

Test plan:

  • pytest tests/unit_tests/test_bucketed_optimizer_redistribution.py tests/unit_tests/test_muon_parameter_prep.py tests/unit_tests/test_deepseek_v3_distributed_muon_config.py -q
  • pytest tests/unit_tests/test_distributed_muon.py::TestDistributedMuon::test_constructor_rejects_storage_shards_that_split_matrices tests/unit_tests/test_distributed_muon.py::TestTensorParallelDistributedMuon::test_distinct_bucket_meshes_use_mesh_local_owners -q (4 GPUs)

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 3, 2026
@weifengpy
weifengpy force-pushed the weifeng/distributed-muon-bucket-mesh branch from 5b79008 to 037a640 Compare August 3, 2026 20:44
@weifengpy
weifengpy force-pushed the weifeng/distributed-muon-bucket-mesh branch from 037a640 to 5abe32e Compare August 3, 2026 20:46
@weifengpy
weifengpy force-pushed the weifeng/distributed-muon-tp-shard1 branch from 159d476 to 084f8c6 Compare August 3, 2026 20:57
@weifengpy

Copy link
Copy Markdown
Contributor Author

Folded into #4034. The rewritten #4051 remains the TP-only follow-up, and its final tree is unchanged.

@weifengpy weifengpy closed this Aug 3, 2026
@weifengpy
weifengpy deleted the weifeng/distributed-muon-bucket-mesh branch August 3, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/8gpu CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant