Relax GraphTrainer stack trace node count test - #4046
Merged
Conversation
wconstab
requested review from
IvanKobzarev,
SherlockNoMad,
aditvenk,
sanketpurandare,
tianyu-l and
xmfan
as code owners
August 1, 2026 02:31
meta-cla
Bot
added
the
CLA Signed
aditvenk
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the shared GraphTrainer failure seen on main and the PP revert PR:
Both fail in
TestMetadataPropagation::test_backward_nodes_have_stack_tracewithAssertionError: 23 != 24, whilebwd_nodes_missing_stack_trace = [].The exact number of eligible FX/autograd nodes is not the behavior this test needs to lock down; it can change as PyTorch tracing/decomposition/autograd internals change. The invariant is that backward nodes corresponding to forward nodes with stack traces also have stack traces. This PR keeps that assertion and only replaces the brittle exact graph-shape count with a sanity check that the test actually examined at least one backward node.
Validation:
python3 -m py_compile torchtitan/experiments/graph_trainer/tests/test_trace_module.pyNote: local
pytestwas unavailable in the default Python environment on my host, so CI should be used for the targeted runtime check. This PR does not address the separate H100 GraphTrainer integration failures.