[CRCR] Add nightly results view to per-repo dashboard - #8441
Merged
Conversation
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
Mockup: Nightly Per-Repo ViewThis is what Key differences from the PR view:
Interactive mockup: https://subinz1.github.io/CRCR/oot-hud-mockup-crcr-nightly.html |
subinz1
marked this pull request as ready for review
August 6, 2026 06:44
The per-repo CRCR page now accepts an `?event=nightly` query parameter to switch between PR-based and nightly results views. When viewing nightly results, the page drops the PR and Author columns and groups rows by SHA instead of PR number, matching the nightly workflow's data model. The CRCR summary page's nightly tab now links repos to `?event=nightly` so clicking a repo name is context-aware. Adds a new `crcr_nightly_dashboard` ClickHouse query that filters by `event_type = 'nightly'` and deduplicates by `max(run_attempt)`.
The summary stats endpoint (crcr_backend_summary) returns PR-specific metrics that aren't rendered on the nightly view. Setting summaryUrl to null when isNightly avoids a wasted ClickHouse query on every nightly page load.
Since pr_number is now optional in CrcrJobRow (the nightly query doesn't return it), buildMatrix could silently collapse rows with undefined pr_number into a single map key. Skip rows with missing or non-positive pr_number to prevent this.
Instead of showing fabricated "nightly release (sha...)" text, use the existing commit-info API endpoint to fetch real commit titles from GitHub via GraphQL. Falls back to the SHA-based placeholder while the API response is loading or if it fails.
When the user changes the time range on the CRCR summary page (e.g. to 30 days), clicking through to a repo's nightly view now preserves that selection instead of resetting to the default 7 days.
The nightly view now shows its own stat cards — Pass Rate, Nightly Runs (unique SHAs), and Failures — computed client-side from the already-fetched ClickHouse data. This fills the visual gap left by hiding the PR-specific cards.
The SQL_PARAMS linter requires params.json to have 'params' and 'tests' keys. Update to match the expected format used by all other ClickHouse queries.
Correct JSX indentation inside the fragment wrapper in CrcrNightlyMatrix, and collapse the short pageTitle ternary to a single line as Prettier expects.
Collapse short filter chain and tr element props to single lines as Prettier expects.
subinz1
force-pushed
the
crcr-nightly-per-repo-view
branch
from
August 6, 2026 15:00
48af7e8 to
80e5ec6
Compare
The nightly view's commit title cell uses MUI's Tooltip component but it was never imported, causing a react/jsx-no-undef lint error.
Import CSSProperties from React (used by table style constants) and pass the required sha prop to GroupedJobCell and JobCell in the nightly view, matching how the PR matrix already passes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?event=nightlyquery parameter support to the per-repo CRCR dashboard page (/crcr/{org}/{repo})event=nightly, the page shows nightly CI results grouped by SHA with Time/SHA/Commit columns (no PR number or author)/crcr/{org}/{repo}?event=nightlyso navigation is context-awarecrcr_nightly_dashboardClickHouse query that filters byevent_type = 'nightly'and deduplicates bymax(run_attempt)perrun_id + job_nameNavigation flow
/crcr/{org}/{repo}(default, PR results)/crcr/{org}/{repo}?event=nightly(nightly results)Mockup
Test plan
/crcr/{org}/{repo}— should show PR-based results (default behavior unchanged)/crcr/{org}/{repo}?event=nightly— should show nightly results grouped by SHA?event=nightly