Remove linux_job.yml (v1) and its test workflow - #8417
Draft
huydhn wants to merge 1 commit into
Draft
Conversation
linux_job_v2.yml supersedes it: v1's workflow_call inputs are a strict subset of v2's, and v2 adds ROCm and XPU setup and teardown on top. Nothing in this repo references v1 any more. Callers migrate by pointing at linux_job_v2.yml; no input changes are needed.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
.github/workflows/linux_job.ymland.github/workflows/test_linux_job.yml. Nothing in this repo references v1 any more.linux_job_v2.ymlsupersedes it — v1'sworkflow_callinputs are a strict subset of v2's (v2 addsadditional-fetch-refs,checkout-mode,single-branch,use-custom-docker-registry), and v2 additionally sets up and tears down ROCm and XPU. Neither takes secrets. So callers migrate by changing theuses:line; no input changes needed.Draft: do not merge until the callers below are migrated. They all pin
@main, so merging breaks their CI immediately. From GitHub code search acrosspytorch/pytorch-labs/meta-pytorch:pytorch/executorch—.github/workflows/trunk.yml:85pytorch/rl—.github/workflows/docs.yml:223pytorch/tensordict—.github/workflows/docs.yml:115pytorch/pytorch-integration-testing—.github/workflows/inductor.yml:21,.github/actions/inductor-test/action.yml:20pytorch/hub—.github/workflows/run_torchhub.yml:18(last push 2024-04)meta-pytorch/multipy—.github/workflows/build_test_release.yaml:24(last push 2025-12)pytorch/ao—torchao/csrc/README.md:30(docs only, no CI impact)executorch, rl, tensordict and pytorch-integration-testing were all pushed to today.
Code search only indexes default branches and caps results, and the unfiltered query returns 100+ hits dominated by third-party forks, so there are likely external users outside these orgs too. Worth deciding whether v1 gets a deprecation window before the delete lands.