Skip to content

Fix toggle test #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scotts wants to merge 3 commits into from
+11 −2
Closed

Fix toggle test #1369

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb0a85a
Test CI
scotts Apr 16, 2026
c8ba9aa
Fix test_dynamic_toggle failure caused by toggle's own CUDA events le…
scotts Apr 16, 2026
dbc8c7d
Add a comment
scotts Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions libkineto/src/GenericActivityProfiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,11 +593,20 @@ void GenericActivityProfiler::toggleCollectionDynamic(const bool enable) {
return;
}
toggleState_.store(enable);

// The ordering of conditions and synchronization is deliberate. We
// intentionally synchronize:
//
// - AFTER we disable
// - BEFORE we enable
//
// Both to prevent the synchronization event from showing up in traces.
if (!enable) {
disableGpuTracing();
}
synchronizeGpuDevice();
if (enable) {
enableGpuTracing();
} else {
disableGpuTracing();
}
}

Expand Down
Loading