[Pallas] Separate memory analysis from TensorCore lowering - #3252
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
This was referenced Aug 3, 2026
thcmbs
marked this pull request as draft
August 3, 2026 12:09
thcmbs
changed the title
thcmbs
marked this pull request as ready for review
August 3, 2026 13:46
norx1991
reviewed
Aug 3, 2026
| assert isinstance(scatter, OneHotScatterPlan) | ||
| assert gather.plan is gather_fallback | ||
| assert scatter.plan is scatter_fallback | ||
| assert all(isinstance(pattern, TensorIndexPattern) for pattern in patterns[:1]) |
Contributor
There was a problem hiding this comment.
This line is very convoluted. Suggested to simplify.
norx1991
approved these changes
Aug 3, 2026
stack-info: PR: #3252, branch: gh/thcmbs/4/head
thcmbs
force-pushed
the
gh/thcmbs/4/head
branch
from
August 4, 2026 14:55
6922477 to
0d9c7c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
plan_tilingpreviously turned tensor-indexed operations directly into TensorCore gather/scatter patterns. This mixed shared indexing analysis with a target-specific implementation and makes the result difficult to reuse for other Pallas targets (sparsecore).This PR separates the two:
MemoryAccessrecords the operation, tensor, subscript and indexing patterns.TensorCorePlanafter tiling analysis.