Skip to content

fix(mlx): forward boundary-partitioned getitem instead of indexing a Slot #21441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metascroy merged 2 commits into from
Jul 30, 2026
+5 −1
Merged

fix(mlx): forward boundary-partitioned getitem instead of indexing a Slot #21441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f768be6
fix(mlx): forward boundary-partitioned getitem instead of indexing a …
msluszniak Jul 28, 2026
2dfbd10
Merge branch 'main' into @ms/mlx-getitem-boundary-fix
metascroy Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backends/mlx/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2272,9 +2272,13 @@ def _getitem_handler(P: MLXProgramBuilder, n: Node) -> Slot:
require_kwargs(P.kwargs(n), set(), "operator.getitem")
a, idx = args
out = P.make_or_get_slot(n)
# When the multi-output parent is left outside the partition, the partitioner
# feeds this getitem the already-selected element as a single boundary-input
# Slot (not the source tuple). In that case forward it directly.
src = a[idx] if isinstance(a, (tuple, list)) else a
P.emit(
IdCopyNode(
x=P.slot_to_tid(a[idx]),
x=P.slot_to_tid(src),
out=P.slot_to_tid(out),
)
)
Expand Down
Loading