Skip to content

Revert "Remove c10 shim includes and redundant std type aliases"#21050

Merged
metascroy merged 1 commit into
mainfrom
revert-20900-remove-c10-shim-includes
Jul 21, 2026
Merged

Revert "Remove c10 shim includes and redundant std type aliases"#21050
metascroy merged 1 commit into
mainfrom
revert-20900-remove-c10-shim-includes

Conversation

@metascroy

Copy link
Copy Markdown
Contributor

Reverts #20900

This causes many internal build failures in internal code like:

error: 'using executorch::aten::string_view = class std::basic_string_view<char>' is deprecated [-Werror=deprecated-declarations]
   82 |       ET_UNUSED std::string_view key) const override {

@pytorch-bot

pytorch-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21050

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 135 Pending

As of commit 1a11aa0 with merge base 564e655 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the ci-no-td label Jul 21, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy
metascroy merged commit a19d1ba into main Jul 21, 2026
192 of 198 checks passed
@metascroy
metascroy deleted the revert-20900-remove-c10-shim-includes branch July 21, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants