Resolve Operator fallback to method allocator if temp alloc fails (#20981) (#20981) by rstehle · Pull Request #20981 · pytorch/executorch

rstehle · 2026-07-16T15:42:02Z

Summary:
Currently, the resolve_operator step during method_init will fall back to method allocator if temp allocator is zero or not present.

This change adds logic to fallback to method allocator if temp allocator is present, but insufficient in size for the tensor meta.

Reviewed By: rascani

Differential Revision: D109855815

Pulled By: rstehle

pytorch-bot · 2026-07-16T15:42:06Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20981

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit aa59c9b with merge base d632341 ():

NEW FAILURE - The following job has failed:

Build Presets / apple (ios) / build (gh)
##[error]fatal: Fetched in submodule path 'extension/llm/tokenizers/third-party/json', but it did not contain e6cafa573aac6ed9227f752a5371c0b3f436307d. Direct fetching of that commit failed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2026-07-16T15:42:09Z

The committers listed above are authorized under a signed CLA.

✅ login: rstehle / name: Regan Stehle (67aa6c0)
✅ login: rstehle / name: rstehle (c42c51c)

meta-codesync · 2026-07-16T15:42:11Z

@rstehle has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109855815.

github-actions · 2026-07-16T15:42:49Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…torch#20981) Summary: Currently, the resolve_operator step during method_init will fall back to method allocator if temp allocator is zero or not present. This change adds logic to fallback to method allocator if temp allocator is present, but insufficient in size for the tensor meta. Reviewed By: Andrew-github-user, rascani Differential Revision: D109855815

rstehle · 2026-07-16T16:24:53Z

/easycla

rstehle · 2026-07-16T16:41:35Z

/easycla

meta-codesync · 2026-07-17T16:41:18Z

@rstehle has imported this pull request. If you are a Meta employee, you can view this in D109855815.

rascani · 2026-07-20T20:05:27Z

  // is not provided (or an empty one is provided), we
  // fall back to the method allocator.
-  if (allocator == nullptr || allocator->size() == 0) {
+  if (allocator == nullptr || allocator->size() == 0 || allocator->size() < (sizeof(TensorMeta) * n_args) + (sizeof(executorch::aten::DimOrderType) * kTensorDimensionLimit * n_args)) {


this line will probably fail the lintrunner.

…torch#20981) (pytorch#20981) Summary: Currently, the resolve_operator step during method_init will fall back to method allocator if temp allocator is zero or not present. This change adds logic to fallback to method allocator if temp allocator is present, but insufficient in size for the tensor meta. Reviewed By: rascani Differential Revision: D109855815 Pulled By: rstehle

rstehle · 2026-07-21T17:51:48Z

@pytorchbot rerun -f

pytorch-bot · 2026-07-21T17:51:50Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'rerun' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'lint', 'fix-lint', 'apply-lint', 'cherry-pick')

usage: @pytorchbot [-h]
                   
                   {merge,revert,rebase,label,drci,lint,fix-lint,apply-lint,cherry-pick}
                   ...

Try @pytorchbot --help for more info.

…torch#20981) (pytorch#20981) Summary: Currently, the resolve_operator step during method_init will fall back to method allocator if temp allocator is zero or not present. This change adds logic to fallback to method allocator if temp allocator is present, but insufficient in size for the tensor meta. Reviewed By: rascani Differential Revision: D109855815 Pulled By: rstehle

rstehle · 2026-07-24T14:17:58Z

@pytorchbot merge

pytorch-bot · 2026-07-24T14:18:02Z

Mergebot is not configured for this repository. Please use the merge button provided by GitHub.

…torch#20981) (pytorch#20981) Summary: Currently, the resolve_operator step during method_init will fall back to method allocator if temp allocator is zero or not present. This change adds logic to fallback to method allocator if temp allocator is present, but insufficient in size for the tensor meta. Reviewed By: rascani Differential Revision: D109855815 Pulled By: rstehle

rstehle requested a review from JacobSzwejbka as a code owner July 16, 2026 15:42

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2026

meta-codesync Bot added the meta-exported label Jul 16, 2026

meta-codesync Bot temporarily deployed to cadence July 16, 2026 15:42 Inactive

meta-codesync Bot changed the title ~~Resolve Operator fallback to method allocator if temp alloc fails~~ Resolve Operator fallback to method allocator if temp alloc fails (#20981) Jul 16, 2026

rstehle force-pushed the export-D109855815 branch from 2da43a9 to 186e3df Compare July 16, 2026 15:45

rstehle force-pushed the export-D109855815 branch from 186e3df to 67aa6c0 Compare July 16, 2026 15:48

rascani reviewed Jul 20, 2026

View reviewed changes

rascani approved these changes Jul 20, 2026

View reviewed changes

meta-codesync Bot changed the title ~~Resolve Operator fallback to method allocator if temp alloc fails (#20981)~~ Resolve Operator fallback to method allocator if temp alloc fails (#20981) (#20981) Jul 20, 2026

rstehle force-pushed the export-D109855815 branch from c42c51c to 80baee5 Compare July 20, 2026 20:38

rstehle force-pushed the export-D109855815 branch from 80baee5 to 62a92fb Compare July 20, 2026 20:46

rstehle force-pushed the export-D109855815 branch from 62a92fb to 13f4cb2 Compare July 20, 2026 22:32

rstehle force-pushed the export-D109855815 branch from 13f4cb2 to 6006632 Compare July 20, 2026 22:36

rstehle force-pushed the export-D109855815 branch 2 times, most recently from 886ae56 to 6397c3a Compare July 23, 2026 16:37

rstehle force-pushed the export-D109855815 branch from 6397c3a to fe1c699 Compare July 23, 2026 16:41

rstehle force-pushed the export-D109855815 branch from fe1c699 to 3b945c7 Compare July 27, 2026 15:51

rstehle force-pushed the export-D109855815 branch from 3b945c7 to 18bee5b Compare July 27, 2026 15:54

rstehle force-pushed the export-D109855815 branch from 18bee5b to aa34c12 Compare July 27, 2026 17:44

rstehle force-pushed the export-D109855815 branch 2 times, most recently from 68dc1c4 to b36c074 Compare July 29, 2026 20:46

rstehle force-pushed the export-D109855815 branch 2 times, most recently from 95028f7 to 9de1d3d Compare July 30, 2026 16:51

rstehle force-pushed the export-D109855815 branch from 9de1d3d to 0b30b5e Compare July 30, 2026 16:54

rstehle force-pushed the export-D109855815 branch from 0b30b5e to 480a9e8 Compare July 30, 2026 21:36

rstehle force-pushed the export-D109855815 branch from 480a9e8 to 426c4c4 Compare July 30, 2026 21:39

rstehle force-pushed the export-D109855815 branch from 426c4c4 to aa59c9b Compare July 30, 2026 21:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Resolve Operator fallback to method allocator if temp alloc fails (#20981) (#20981) - #20981

Resolve Operator fallback to method allocator if temp alloc fails (#20981) (#20981)#20981
rstehle wants to merge 1 commit into
pytorch:mainfrom
rstehle:export-D109855815

rstehle commented Jul 16, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

pytorch-bot Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

linux-foundation-easycla Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

rstehle commented Jul 16, 2026

Uh oh!

rstehle commented Jul 16, 2026

Uh oh!

meta-codesync Bot commented Jul 17, 2026

Uh oh!

rascani Jul 20, 2026

Uh oh!

rstehle commented Jul 21, 2026

Uh oh!

pytorch-bot Bot commented Jul 21, 2026

Uh oh!

rstehle commented Jul 24, 2026

Uh oh!

pytorch-bot Bot commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

rstehle commented Jul 16, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20981

❌ 1 New Failure

Uh oh!

linux-foundation-easycla Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meta-codesync Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

This PR needs a release notes: label

Uh oh!

rstehle commented Jul 16, 2026

Uh oh!

rstehle commented Jul 16, 2026

Uh oh!

meta-codesync Bot commented Jul 17, 2026

Uh oh!

rascani Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

rstehle commented Jul 21, 2026

Uh oh!

pytorch-bot Bot commented Jul 21, 2026

Uh oh!

rstehle commented Jul 24, 2026

Uh oh!

pytorch-bot Bot commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rstehle commented Jul 16, 2026 •

edited by meta-codesync Bot

Loading

pytorch-bot Bot commented Jul 16, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Jul 16, 2026 •

edited

Loading

This PR needs a `release notes:` label