Use const_data_ptr/mutable_data_ptr instead of deprecated data_ptr#20958
Use const_data_ptr/mutable_data_ptr instead of deprecated data_ptr#20958cyyever wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20958
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 4 PendingAs of commit bb52040 with merge base 564e655 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Thanks @cyyever! This LGTM, just one cleanup on cuda_mutable_state.cpp |
cbda78d to
fb9f428
Compare
|
Hi @cyyever, thanks for the PR! Could you review the CUDA build CI test failures and fix them? |
d431ebd to
67ec355
Compare
SlimTensor only has data_ptr(), not const_data_ptr/mutable_data_ptr.
67ec355 to
bb52040
Compare
|
@nil-is-all Fixed |
ExecuTorch
Tensor::data_ptrisET_DEPRECATED. Replace remaining call sites: read-only accesses useconst_data_ptr, the rest usemutable_data_ptr(sampler input, CMSIS-NN struct fields, JNI/mmap'd buffers that require non-const pointers).Left unchanged:
backends/aoti/slim(SlimTensor has no const/mutable variants) andat::Tensor::data_ptr()inextension/pybindings(not deprecated;for_blobtakesvoid*).Authored with Claude Code.