osdc/hf-cache: drop --use-mmap, keep buffer-size reduction - #913
Merged
Conversation
Remove --use-mmap from the rclone mount, keeping the --buffer-size 4M read-ahead cut. Both were added together in pytorch#907; we're rolling out one lever at a time, starting with the buffer-size reduction.
huydhn
force-pushed
the
hf-cache-drop-use-mmap
branch
from
July 17, 2026 01:29
31bc5ea to
ba12398
Compare
jeanschmidt
approved these changes
Jul 17, 2026
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
--use-mmapfrom the rclone mount, keeping the--buffer-size 4Mread-ahead cut. Both were added together in #907; we're rolling out one lever at a time, starting with the buffer-size reduction.I want to make one change at a time for this tricky part to make sure that the cause and effect can be seen clearly