Back out "Forward-compat nfp8_dtype fallback for torch.package re-export version blends" - #6091
Open
q10 wants to merge 1 commit into
Open
Back out "Forward-compat nfp8_dtype fallback for torch.package re-export version blends"#6091q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
…ort version blends" Summary: Backs out D113966884. That diff was a Python forward-fix for S685573 layered on top of D113263502. We are now fully reverting D113263502 (via D113962469) because it also caused a HIP binary-size relocation overflow in sigrid.predictor.hip (cxx_relocation_overflow: doubled FP8 kernel instantiations pushed .text past the 2^32 PC-relative limit), which a Python fix cannot address. Backing this out first restores split_table_batched_embeddings_ops_training.py to the D113263502 state so the D113263502 backout (D113962469) applies cleanly and the tree returns to the exact pre-D113263502 state. Left in place, this forward-compat shim would become dead code (split_embedding_configs loses nfp8_dtype after the D113263502 backout, so the try-import always hits the fallback). Reviewed By: ericluometa Differential Revision: D114033024
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114033024. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Backs out D113966884. That diff was a Python forward-fix for S685573 layered
on top of D113263502. We are now fully reverting D113263502 (via D113962469)
because it also caused a HIP binary-size relocation overflow in
sigrid.predictor.hip (cxx_relocation_overflow: doubled FP8 kernel
instantiations pushed .text past the 2^32 PC-relative limit), which a Python
fix cannot address.
Backing this out first restores split_table_batched_embeddings_ops_training.py
to the D113263502 state so the D113263502 backout (D113962469) applies cleanly
and the tree returns to the exact pre-D113263502 state. Left in place, this
forward-compat shim would become dead code (split_embedding_configs loses
nfp8_dtype after the D113263502 backout, so the try-import always hits the
fallback).
Reviewed By: ericluometa
Differential Revision: D114033024