Skip HSTU paged-KV test when SM80 kernels are unavailable - #6085
Open
q10 wants to merge 1 commit into
Open
Conversation
Summary: The OSS HSTU CUDA CI lane builds the HSTU wheel without arch 8.0 in TORCH_CUDA_ARCH_LIST, so the Ampere `fbgemm::hstu_varlen_fwd_80` op is never registered (see CMakeLists.txt, which only compiles the Ampere sources when "8.0" is in TORCH_CUDA_ARCH_LIST). On the Ampere-class GitHub runner (A10G, capability (8, 6)), `HSTUPagedKVTest::test_paged_kv_attn` dispatches to that op and fails with: AttributeError: '_OpNamespace' 'fbgemm' object has no attribute 'hstu_varlen_fwd_80' Gate the SM80-specific paged-KV test on a new `has_sm80_hstu_support()` helper that requires both an Ampere (major version 8) device and the `hstu_varlen_fwd_80` op to actually be present in the build, so the test skips instead of erroring when the SM80 kernels are not compiled. A pure device-capability check is insufficient because the failing runner is major version 8 but simply lacks the compiled op. Reviewed By: henrylhtsang Differential Revision: D113933857
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113933857. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The OSS HSTU CUDA CI lane builds the HSTU wheel without arch 8.0 in
TORCH_CUDA_ARCH_LIST, so the Ampere
fbgemm::hstu_varlen_fwd_80op isnever registered (see CMakeLists.txt, which only compiles the Ampere
sources when "8.0" is in TORCH_CUDA_ARCH_LIST). On the Ampere-class
GitHub runner (A10G, capability (8, 6)),
HSTUPagedKVTest::test_paged_kv_attndispatches to that op and fails with:AttributeError: '_OpNamespace' 'fbgemm' object has no attribute 'hstu_varlen_fwd_80'
Gate the SM80-specific paged-KV test on a new
has_sm80_hstu_support()helper that requires both an Ampere (major version 8) device and the
hstu_varlen_fwd_80op to actually be present in the build, so the testskips instead of erroring when the SM80 kernels are not compiled. A pure
device-capability check is insufficient because the failing runner is
major version 8 but simply lacks the compiled op.
Reviewed By: henrylhtsang
Differential Revision: D113933857