feat: Implement Comprehensive ONNX Export Testing and Validation (#654)#660
Draft
SHIVANSH-ux-ys wants to merge 2 commits into
Draft
feat: Implement Comprehensive ONNX Export Testing and Validation (#654)#660SHIVANSH-ux-ys wants to merge 2 commits into
SHIVANSH-ux-ys wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #654 by implementing a robust validation rig for ONNX export. It moves the ONNX export functionality from "experimental" to a reliable feature by fixing several core bugs and adding comprehensive testing.
Key Changes:
save_model_for_inferenceto handle dynamic batch sizes and feature configurations (only continuous, only categorical, or mixed)..eval()mode switching during export to ensure consistency.onnxandonnxruntimeto optional dependencies.NameErrorin the test suite and updatedtest_save_for_inference_onnxto perform numerical validation comparing PyTorch and ONNX outputs.Verification:
onnx.checkervalidation during the export process.Closes #654