documentation#63
Merged
alexsquires merged 3 commits intopythoninchemistry:masterfrom May 21, 2020
alexsquires:master
Merged
Conversation
Contributor
|
Thoughts:
I like this |
Collaborator
Author
My thinking here was that docstrings require an appreciation of functions, but I don't feel like an understanding of basic documentation should necessitate understanding functions, so I separated them out. I'm not strongly attached to this way of working though. |
Contributor
|
I personally would be happy with them together, just change the name of that subsection to "Docstrings" or something and add functions to the overall prerequisites (this part will definitely be coming after the functions part in the structure of the book so it should be fine). |
arm61
approved these changes
May 21, 2020
Contributor
|
Happy for you to merge this @alexsquires |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a documentation section with a focus on writing as opposed to reading. I thought this would be a doss, but turns out it's hard. Happy to be beaten over the head with the opinions of others.