Update the arcade window so it resets gl context properly everyframe.#2752
Closed
DragonMoffon wants to merge 5 commits intodevelopmentfrom
Closed
Update the arcade window so it resets gl context properly everyframe.#2752DragonMoffon wants to merge 5 commits intodevelopmentfrom
DragonMoffon wants to merge 5 commits intodevelopmentfrom
Conversation
…e unit tests from corrupting camera state
einarf
reviewed
Jul 15, 2025
Comment on lines
315
to
317
| self.enable_only(self.BLEND) | ||
| self.blend_func = self.BLEND_DEFAULT | ||
| self.point_size = 1.0 |
Member
There was a problem hiding this comment.
The reset method was more for unit tests. We can still probably trim it down. These lines should definitly not be called every frame but they should be called in conftest between tests except that blending needs to disable instead.
I also don't know if it's necessary to bind the windowblock every frame but that should be done in unit tests.
Collaborator
Author
|
I've closed this PR, as it was doing two things. There are code fixes for Camera that are here that should be merged, while the context resetting should be handled better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed a while ago as part of the 3.0 changes. I put it off so that 3.0 could be released, and because there were larger issues with it to be solved. That work still needs doing.
The
ArcadeContextreset method used by unit tests did not work well. It has now been updated to use the default camera rather than setting theProjectionandViewmatrices manually.The GL state was not being reset before every
on_drawdispatch. This PR makes it so the gl state is reset, the screen's framebuffer is active, and the default camera is the active before everyon_draw. The consequences of this change on examples and unit tests should be checked before the PR is merged.