Skip to content

Add timing output to subprocess commands in make.py#2724

Merged
einarf merged 2 commits intopythonarcade:developmentfrom
alanJoshiGeorge:add-timing-to-make
Jun 23, 2025
Merged

Add timing output to subprocess commands in make.py#2724
einarf merged 2 commits intopythonarcade:developmentfrom
alanJoshiGeorge:add-timing-to-make

Conversation

@alanJoshiGeorge
Copy link
Contributor

No description provided.

This comment was marked as outdated.

@einarf einarf requested a review from pushfoo June 10, 2025 15:45
@einarf
Copy link
Member

einarf commented Jun 14, 2025

@alanJoshiGeorge Do you know how to proceed? If not .. scream and we'll help.

@einarf einarf requested a review from Copilot June 15, 2025 20:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds timing measurement to the subprocess command execution in make.py.

  • Introduces time.perf_counter to measure execution time.
  • Formats and prints the elapsed time in hours, minutes, and seconds.

@einarf
Copy link
Member

einarf commented Jun 15, 2025

Just do a python make.py format to sort the imports and this is good 👍

@pushfoo
Copy link
Member

pushfoo commented Jun 15, 2025

I'm fine with it as-is (post-./make.py format):

  • There may be a timezone issue now and then
  • Python 3.13's perf_counter is a monotonic counter which avoids them

@einarf einarf merged commit 3c61332 into pythonarcade:development Jun 23, 2025
6 of 7 checks passed
@einarf
Copy link
Member

einarf commented Jun 23, 2025

I fixed the remaining issue and merged. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants