Skip to content

Lights without geometry shader#2716

Merged
einarf merged 1 commit intodevelopmentfrom
lights-no-geo
Jun 7, 2025
Merged

Lights without geometry shader#2716
einarf merged 1 commit intodevelopmentfrom
lights-no-geo

Conversation

@einarf
Copy link
Member

@einarf einarf commented Jun 7, 2025

No description provided.

@einarf einarf requested a review from Copilot June 7, 2025 22:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the existing geometry‐shader–based point light rendering with instanced quads generated in the vertex shader and updates the Python client code accordingly.

  • Point light vertex shader now handles per‐instance data and quad expansion.
  • Geometry shader file removed.
  • Python lights.py updated to use instanced TRIANGLE_STRIP rendering and renamed uniform.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
arcade/resources/system/shaders/lights/point_lights_vs.glsl Switched to instanced attributes, added offset uniform, outputs UV/color/attenuation
arcade/resources/system/shaders/lights/point_lights_geo.glsl Removed unused geometry shader
arcade/resources/system/shaders/lights/point_lights_fs.glsl Minor formatting adjustment
arcade/future/light/lights.py Updated VAO setup for instancing, removed geometry shader usage, changed render call

@einarf einarf merged commit c5d70f5 into development Jun 7, 2025
7 checks passed
@einarf einarf deleted the lights-no-geo branch June 7, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants