Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds unbuffered, geometry-shader-free implementations for ellipse drawing and cleans up related context and draw logic.
- Vertex shaders now generate ellipse (filled and outline) geometry on the fly, removing the need for geometry shaders.
circle.pyandcontext.pyupdated to eliminate buffering/orphaning and to auto-select segment counts.- Minor adjustment in rectangle vertex shader for consistent operator grouping.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| arcade/resources/system/shaders/shapes/rectangle/filled_unbuffered_vs.glsl | Reordered rotation and translation operations for clarity |
| arcade/resources/system/shaders/shapes/ellipse/outline_unbuffered_vs.glsl | Complete rewrite to compute outline vertices in vertex shader |
| arcade/resources/system/shaders/shapes/ellipse/outline_unbuffered_geo.glsl | Removed—no longer needed |
| arcade/resources/system/shaders/shapes/ellipse/filled_unbuffered_vs.glsl | New vertex-only fill logic |
| arcade/resources/system/shaders/shapes/ellipse/filled_unbuffered_geo.glsl | Removed—no longer needed |
| arcade/draw/circle.py | Removed buffer writes and added auto-segment logic |
| arcade/context.py | Dropped geometry-shader setup and unused buffers |
Comments suppressed due to low confidence (1)
arcade/context.py:260
- Add a brief comment explaining that the geometry is intentionally empty and that all vertex positions are generated in the vertex shader.
self.shape_ellipse_unbuffered_geometry: Geometry = self.geometry()
arcade/resources/system/shaders/shapes/ellipse/outline_unbuffered_vs.glsl
Show resolved
Hide resolved
arcade/resources/system/shaders/shapes/ellipse/outline_unbuffered_vs.glsl
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.