Skip to content

Circle / ellipse no geo shader#2715

Merged
einarf merged 4 commits intodevelopmentfrom
circle-no-geo
Jun 7, 2025
Merged

Circle / ellipse no geo shader#2715
einarf merged 4 commits intodevelopmentfrom
circle-no-geo

Conversation

@einarf
Copy link
Member

@einarf einarf commented Jun 7, 2025

No description provided.

@einarf einarf requested a review from Copilot June 7, 2025 20:12

This comment was marked as outdated.

@einarf einarf requested a review from Copilot June 7, 2025 21:43
@einarf einarf marked this pull request as ready for review June 7, 2025 21:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds unbuffered, geometry-shader-free implementations for ellipse drawing and cleans up related context and draw logic.

  • Vertex shaders now generate ellipse (filled and outline) geometry on the fly, removing the need for geometry shaders.
  • circle.py and context.py updated to eliminate buffering/orphaning and to auto-select segment counts.
  • Minor adjustment in rectangle vertex shader for consistent operator grouping.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
arcade/resources/system/shaders/shapes/rectangle/filled_unbuffered_vs.glsl Reordered rotation and translation operations for clarity
arcade/resources/system/shaders/shapes/ellipse/outline_unbuffered_vs.glsl Complete rewrite to compute outline vertices in vertex shader
arcade/resources/system/shaders/shapes/ellipse/outline_unbuffered_geo.glsl Removed—no longer needed
arcade/resources/system/shaders/shapes/ellipse/filled_unbuffered_vs.glsl New vertex-only fill logic
arcade/resources/system/shaders/shapes/ellipse/filled_unbuffered_geo.glsl Removed—no longer needed
arcade/draw/circle.py Removed buffer writes and added auto-segment logic
arcade/context.py Dropped geometry-shader setup and unused buffers
Comments suppressed due to low confidence (1)

arcade/context.py:260

  • Add a brief comment explaining that the geometry is intentionally empty and that all vertex positions are generated in the vertex shader.
self.shape_ellipse_unbuffered_geometry: Geometry = self.geometry()

@einarf einarf merged commit 72599fc into development Jun 7, 2025
7 checks passed
@einarf einarf deleted the circle-no-geo branch June 7, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants