Skip to content

Fix broken link (#2706)#2708

Merged
pushfoo merged 1 commit intopythonarcade:developmentfrom
Infamous003:fix-broken-link
May 30, 2025
Merged

Fix broken link (#2706)#2708
pushfoo merged 1 commit intopythonarcade:developmentfrom
Infamous003:fix-broken-link

Conversation

@Infamous003
Copy link
Contributor

No description provided.

Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is some very good attention to detail! 👀

For future readers

We're linking the element ID in the generated HTML because:

  1. Sphinx has a long-standing issue with :target: as a reference
  2. We need the thumbnail to be clickable now
  3. Some example pages may end up holding multiple headings
  4. Sphinx uses <span id="shapes-slow"></span> and similar as link headings
  5. Adding #shapes-slow ID targets the specific one in question in a somewhat future-proof way

A better future solution would help, but this is excellent work!

@pushfoo pushfoo merged commit d497e25 into pythonarcade:development May 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants