Fix broken link (#2706)#2708
Merged
pushfoo merged 1 commit intopythonarcade:developmentfrom May 30, 2025
Merged
Conversation
pushfoo
approved these changes
May 30, 2025
Member
pushfoo
left a comment
There was a problem hiding this comment.
Thank you! This is some very good attention to detail! 👀
For future readers
We're linking the element ID in the generated HTML because:
- Sphinx has a long-standing issue with
:target:as a reference- See sphinx-doc/sphinx#4351)
- Maybe it will be fixed one day
- Don't expect it any time soon
- We need the thumbnail to be clickable now
- Some example pages may end up holding multiple headings
- Sphinx uses
<span id="shapes-slow"></span>and similar as link headings - Adding
#shapes-slowID targets the specific one in question in a somewhat future-proof way
A better future solution would help, but this is excellent work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.