Add method for syncing a Sprite's hitbox to it's pymunk Shape#2691
Merged
Cleptomania merged 3 commits intodevelopmentfrom May 20, 2025
Merged
Add method for syncing a Sprite's hitbox to it's pymunk Shape#2691Cleptomania merged 3 commits intodevelopmentfrom
Cleptomania merged 3 commits intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if you updated the texture of a Sprite(and in turn, it's hitbox) or just updated the hitbox of the sprite through any means. This change does not propagate to Pymunk when using the builtin pymunk physics engine. In order to make this happen currently you need to remove and re-add the sprite to the engine, which is a costly operation.
This adds a new method to the physics engine for triggering an update of a sprite. Which generates a new Pymunk shape based on the current hitbox of the sprite, and replaces the existing shape with it. This should be much less costly then fully removing/re-adding the Sprite.
Currently this is not automatically triggered so it's still up to the user on calling this function to update the sprite, open to ideas on how this can be triggered automatically when the Sprite's hitbox is synced to the texture for example.